[android] Add a way to use a custom location source #8710

Guardiola31337 · 2017-04-11T14:16:54Z

tobrun

Looking great, could we add a test around this? maybe adding a mock example in the test app (could be integrated in an existing activity)? Changelog entry would be appreciated

zugaldia · 2017-04-12T18:05:22Z

platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapboxMap.java

+   *                       location source.
+   */
+  @UiThread
+  public void setLocationSource(@Nullable LocationEngine locationSource) {


Let's call this setLocationEngine.

zugaldia · 2017-04-12T18:05:59Z

...orm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/TrackingSettings.java

@@ -362,6 +365,11 @@ void setMyLocationEnabled(boolean locationEnabled) {
    myLocationView.setEnabled(locationEnabled);
  }

+  void setLocationSource(LocationEngine locationSource) {


Similarly, let's call it setLocationEngine().

zugaldia · 2017-04-12T18:07:22Z

...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java

@@ -58,6 +58,7 @@

  private LatLng latLng;
  private Location location;
+  private LocationEngine locationSource;


I'd rather call it locationEngine even if LocationSource is our default implementation.

zugaldia · 2017-04-12T18:08:13Z

...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java

@@ -561,22 +563,29 @@ public void setContentPadding(int[] padding) {
    contentPaddingY = (padding[1] - padding[3]) / 2;
  }

+  public void setLocationSource(LocationEngine locationSource) {


Same: setLocationEngine().

zugaldia · 2017-04-12T18:08:53Z

...droid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/widgets/MyLocationView.java

  private static class GpsLocationListener implements LocationEngineListener {

    private WeakReference<MyLocationView> userLocationView;
+    private WeakReference<LocationEngine> locationSource;


Similarly, let's call the variable locationEngine.

zugaldia · 2017-04-18T18:23:15Z

...in/java/com/mapbox/mapboxsdk/testapp/activity/userlocation/CustomLocationEngineActivity.java

+      @Override
+      public void onClick(View view) {
+        if (mapboxMap != null) {
+          mapboxMap.setLocationSource(locationServices);


@Guardiola31337 Do we need to set a location source every time the FAB is clicked? Wouldn't we need to set it just once if it hasn't been set before? Also, I don't see a getLocationSource() method to check that, or alternatively a isCustomLocationSourceSet().

@zugaldia you're right, setting it once would be enough.
I don't see the necessity of having getLocationSource or isCustomLocationSourceSet methods, because if it isn't set we use LocationSource (default). What would be the use case?

What would be the use case?

@Guardiola31337 Check if it's been set or not. For example, this activity could've been written like:

if (mapboxMap.getLocationSource() == null) { mapboxMap.setLocationSource(locationServices); }

@zugaldia there is always a location source. It can't be null. So it doesn't make sense.

@Guardiola31337 Alternatively:

if (mapboxMap.getLocationSource() instanceof MyCustomLocationSource) { // Safe cast }

Ehekatl · 2017-05-15T04:16:44Z

I manage to use this to fix issue #8639 #8848
However after I change location source to my own location engine in background service, the map view lost the ability to update user location gradually and start jumping to the new position immediately on location change.
Is there any way to solve it?

zugaldia · 2017-05-15T13:48:37Z

@Ehekatl thanks for the report. I'd like to explore the root cause for this misbehavior. Could you open a new ticket and, if possible, share the code for your custom location engine? For reference, we provide a sample implementation of a custom location engine on CustomLocationEngineActivity

Guardiola31337 added Android Mapbox Maps SDK for Android feature Google Maps parity For feature parity with the Google Maps SDK for Android or iOS localization Human language support and internationalization labels Apr 11, 2017

Guardiola31337 requested review from tobrun and zugaldia April 11, 2017 14:16

Guardiola31337 force-pushed the pg-8668-location-source branch from 86488cd to d3faa66 Compare April 11, 2017 16:48

tobrun suggested changes Apr 12, 2017

View reviewed changes

zugaldia suggested changes Apr 12, 2017

View reviewed changes

This was referenced Apr 12, 2017

locationEngine needed? mapbox/mapbox-android-demo#248

Closed

Location service doesn't stop after closing app #8683

Closed

Guardiola31337 force-pushed the pg-8668-location-source branch 2 times, most recently from 3058fa6 to 3ac6ad6 Compare April 13, 2017 14:57

tobrun force-pushed the pg-8668-location-source branch from 3ac6ad6 to 827da47 Compare April 13, 2017 15:23

Guardiola31337 force-pushed the pg-8668-location-source branch from 827da47 to 652bde0 Compare April 13, 2017 16:07

tobrun approved these changes Apr 18, 2017

View reviewed changes

zugaldia reviewed Apr 18, 2017

View reviewed changes

Guardiola31337 added 2 commits April 19, 2017 10:10

add a way to use a custom location source

0add924

add custom location engine example to test app

4837b17

Guardiola31337 force-pushed the pg-8668-location-source branch from 652bde0 to 4837b17 Compare April 19, 2017 08:14

tobrun mentioned this pull request Apr 19, 2017

MyLocation view position is wrong after disable my location a while #6167

Closed

zugaldia approved these changes Apr 20, 2017

View reviewed changes

Guardiola31337 merged commit c6be40b into master Apr 20, 2017

Guardiola31337 deleted the pg-8668-location-source branch April 20, 2017 18:10

tobrun mentioned this pull request May 2, 2017

Release Android v5.1.0-beta1 #8856

Closed

12 tasks

tobrun added this to the android-v5.1.0 milestone May 4, 2017

This was referenced May 18, 2017

Release Android v5.1.0-beta2 #8975

Closed

Release Android v5.1.0-beta.3 #9114

Closed

tobrun mentioned this pull request Jun 9, 2017

Release Android v5.1.0-beta.4 #9231

Closed

12 tasks

tobrun mentioned this pull request Jun 21, 2017

Release Android v5.1.0-beta.5 #9315

Closed

11 tasks

tobrun mentioned this pull request Jun 30, 2017

Release Android v5.1.0 #9404

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android] Add a way to use a custom location source #8710

[android] Add a way to use a custom location source #8710

Guardiola31337 commented Apr 11, 2017

tobrun left a comment

zugaldia Apr 12, 2017

zugaldia Apr 12, 2017

zugaldia Apr 12, 2017

zugaldia Apr 12, 2017

zugaldia Apr 12, 2017

zugaldia Apr 18, 2017 •

edited

Loading

Guardiola31337 Apr 18, 2017

zugaldia Apr 20, 2017

Guardiola31337 Apr 20, 2017

zugaldia Apr 20, 2017

Ehekatl commented May 15, 2017

zugaldia commented May 15, 2017

[android] Add a way to use a custom location source #8710

[android] Add a way to use a custom location source #8710

Conversation

Guardiola31337 commented Apr 11, 2017

tobrun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zugaldia Apr 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ehekatl commented May 15, 2017

zugaldia commented May 15, 2017

zugaldia Apr 18, 2017 •

edited

Loading