Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] - Transifex intregration and Dutch translations. #8556

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Mar 29, 2017

This PR adds mapbox-gl-native Transifex project integration for the Android Mapbox SDK.
To test integration, Dutch translations were added.

@1ec5 I moved the lang_map of the previous integration to the specific tasks (Android follows
the ISO 639-1 standard). I feel this was the best solution as applying a lang_map to a specific task will not override the project lang_map but will extend it.

cc @mapbox/android

@tobrun tobrun added Android Mapbox Maps SDK for Android localization Human language support and internationalization labels Mar 29, 2017
@tobrun tobrun added this to the android-v5.1.0 milestone Mar 29, 2017
@tobrun tobrun self-assigned this Mar 29, 2017
@tobrun tobrun requested a review from 1ec5 March 29, 2017 10:00
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @1ec5 to be potential reviewers.

@zugaldia
Copy link
Member

@tobrun I believe this is worth including in the CHANGELOG.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A run of tx pull -a shows that this PR works as advertised. I did notice that tx changed several existing .strings files back to UTF-16 encoding (which git treats as binary), so we’ll have to keep an eye out for that and restore UTF-8 encoding to those files.

Incidentally, you may want to run tx pull -a to get the Catalan translation, which has been updated in Transifex to cover the new Android strings! 🎉

If you haven’t already, don’t forget to configure Transifex to fetch the raw version of strings.xml daily.

@tobrun
Copy link
Member Author

tobrun commented Mar 30, 2017

A run of tx pull -a shows that this PR works as advertised. I did notice that tx changed several existing .strings files back to UTF-16 encoding (which git treats as binary), so we’ll have to keep an eye out for that and restore UTF-8 encoding to those files.

I saw this as well, wasn't sure if this was expected behavior. Thank you for adding this.

Incidentally, you may want to run tx pull -a to get the Catalan translation, which has been updated in Transifex to cover the new Android strings! 🎉

Wow, that was fast! or should I say: això va ser ràpid.

If you haven’t already, don’t forget to configure Transifex to fetch the raw version of strings.xml daily.

I haven't, will look into it.

@Guardiola31337
Copy link
Contributor

@tobrun 😂

Wow, that was fast! or should I say: això va ser ràpid.

^ què ràpid! 👍

@tobrun tobrun merged commit 6c92199 into master Mar 30, 2017
@tobrun tobrun deleted the tvn-transifex-integration branch March 30, 2017 15:00
@1ec5 1ec5 added the Google Maps parity For feature parity with the Google Maps SDK for Android or iOS label Mar 30, 2017
@tobrun tobrun mentioned this pull request May 2, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 9, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android Google Maps parity For feature parity with the Google Maps SDK for Android or iOS localization Human language support and internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants