This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] - only dispatch events if not handled by MarkerView #8447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tobrun
force-pushed
the
8444-markerview-click
branch
from
90af112
to
3c7fbd0
Compare
|
Retesting this and we actually need to be able to handle touches that are handled by the child views.. this makes starting a pan on a MarkerView impossible. |
|
Will need to re implement the OnClick logic with OnTouch to be able to control the flag returned to MarkerViewContainer. |
tobrun
force-pushed
the
8444-markerview-click
branch
from
3c7fbd0
to
8f38a77
Compare
|
8f38a77 fixes the issue, want to review @Guardiola31337? |
tobrun
removed
the
⚠️ DO NOT MERGE
| select(marker, v, adapter); | ||
| @Override | ||
| public boolean onTouch(View v, MotionEvent event) { | ||
| switch (event.getAction()) { |
There was a problem hiding this comment.
Why using switch instead if? There is only one case (MotionEvent.ACTION_UP).
There was a problem hiding this comment.
Comment fixed in 430f9f6
use onTouch listener to ignore dispatching action up events to MapView when they are already handled by MarkerView.
tobrun
force-pushed
the
8444-markerview-click
branch
from
8f38a77
to
430f9f6
Compare
This was referenced Mar 17, 2017
Closed
tobrun
added a commit
that referenced
this pull request
Mar 30, 2017
* Revert "[android] - only dispatch events if not handled by MarkerView (#8447)" This reverts commit 09d7685. * Revert "[android] - move touch handling of MarkerViews back to View#setOnClickListener. Workaround panning issue by dispatching touch events to the parent ViewGroup. (#8272)" This reverts commit 1693b38.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8444