This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move MarkerView click handling back to View#setOnClickListener #8272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kListener. Workaround panning issue by dispatching touch events to the parent ViewGroup.
| @@ -503,6 +503,21 @@ public void invalidateViewMarkersInVisibleRegion() { | |||
| } | |||
| } | |||
|
|
|||
| adaptedView.setOnClickListener(new View.OnClickListener() { | |||
There was a problem hiding this comment.
Just a thought, we should refactor invalidateViewMarkersInVisibleRegion method. The longer a procedure is, the more difficult it’s to understand. It's an easy refactor, 99% of the times extract a method. What do you think?
There was a problem hiding this comment.
yes, this has been on my list todo for a while, this method should be split up into smaller methods 👍
| if (marker instanceof MarkerView) { | ||
| handledDefaultClick = markerViewManager.onClickMarkerView((MarkerView) marker); | ||
| } else { | ||
| if (!(marker instanceof MarkerView)) { |
There was a problem hiding this comment.
We should refactor AnnotationManager class (actually I'm working on it 😅 ). It has a lot of responsibilities.
There was a problem hiding this comment.
yes, looking forward to that PR ;)
Guardiola31337
approved these changes
Mar 9, 2017
This was referenced Mar 14, 2017
Closed
tobrun
added a commit
that referenced
this pull request
Mar 30, 2017
* Revert "[android] - only dispatch events if not handled by MarkerView (#8447)" This reverts commit 09d7685. * Revert "[android] - move touch handling of MarkerViews back to View#setOnClickListener. Workaround panning issue by dispatching touch events to the parent ViewGroup. (#8272)" This reverts commit 1693b38.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8236, refs # 8159 #5388 #5639
This PR moves touch handling of MarkerViews back to View#setOnClickListener and fixes the issue with the original implementation as shown in #5388.
This change is motivated by 2 items: