Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] #5388 - moves touch handling of MarkerViews to core #5639

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 11, 2016

Refers #5388.

Notes:

  • Moves touch interaction of MarkerViews to core
  • Replaced average icon width/height for touch surface padding to a fixed size, since this was giving incorrect results. Will need to revisit later to fix this.
  • Noticed some strange behaviour that click events were not triggered and had to wait a couple of seconds before being able to click the map.

@tobrun tobrun added Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Jul 11, 2016
This was referenced Jul 26, 2016
@tobrun tobrun added this to the android-v4.2.0 milestone Aug 3, 2016
@tobrun tobrun force-pushed the 5388-touch-events-markerviews branch from 42ad541 to 9c2aa3f Compare August 17, 2016 08:12
@tobrun
Copy link
Member Author

tobrun commented Aug 17, 2016

Rebased, and working on resolving the second bullet in OP.

@tobrun
Copy link
Member Author

tobrun commented Aug 17, 2016

It seems now that the underlying logic has shifted to a queryPointAnnotations had broken the way his PR was setup. Need to look into resolving this issue first.

@tobrun
Copy link
Member Author

tobrun commented Aug 18, 2016

@SylvainHocq I'm currently blocked to merge this since the underlying logic has changed when it comes to getting annotations in a bounds. That issue is documented here. #6055

@SylvainHocq
Copy link
Contributor

@tobrun Yes, in fact, i see a problem: the onMarkerClick it never call now

@tobrun tobrun self-assigned this Sep 21, 2016
@voidel
Copy link

voidel commented Sep 24, 2016

This can't come soon enough, especially for us that override the default marker view.

Thanks for all your work so far, @tobrun

@tobrun tobrun force-pushed the 5388-touch-events-markerviews branch from 9c2aa3f to 4ab9718 Compare October 25, 2016 08:33
@tobrun tobrun added ✓ ready for review and removed ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Oct 25, 2016
@tobrun
Copy link
Member Author

tobrun commented Oct 25, 2016

Rebased on master after #6773 got merged and the PR is now working again.
Would you be able to review after CI approves @ivovandongen?

Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tobrun tobrun mentioned this pull request Oct 25, 2016
@tobrun tobrun merged commit 94b1a53 into master Oct 25, 2016
@tobrun tobrun deleted the 5388-touch-events-markerviews branch October 25, 2016 13:11
@LornTao LornTao restored the 5388-touch-events-markerviews branch December 1, 2016 03:45
@LornTao LornTao deleted the 5388-touch-events-markerviews branch December 1, 2016 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants