This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Retain thread pool in GeoJSONSource #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the construction of the `Immutable<Source::Impl>` in background thread might never yeld.
jmalanen
approved these changes
Nov 29, 2019
|
Note for the change log: "Fixed the possible GeoJSON source hanging, caused by early thread pool deletion" |
|
@tobrun @julianrex this must be back-ported to the branches, which contain e6e6bcf |
pozdnyakov
added
the
needs backport
alexshalamov
approved these changes
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the construction of the
Immutable<Source::Impl>in background thread might never yeld.