Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Fix supercluster lambdas capturing #15989

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Conversation

pozdnyakov
Copy link
Contributor

  • fix wrapping of the parameters in supercluster map/reduce lambdas (Previously, local variables were wrapped by reference).
  • share the GeoJSONOptions instances using Immutable<GeoJSONOptions> - avoid extra copying

@pozdnyakov pozdnyakov self-assigned this Nov 28, 2019
@pozdnyakov pozdnyakov added bug Core The cross-platform C++ core, aka mbgl needs backport Indicates PR needs to be cherrypicked into a previous release branch. labels Nov 28, 2019
@pozdnyakov pozdnyakov force-pushed the mikhail_fix_supercluster branch 2 times, most recently from 09dd3e2 to 1c7c4b2 Compare November 28, 2019 17:13
@pozdnyakov pozdnyakov marked this pull request as ready for review November 28, 2019 17:22
@pozdnyakov pozdnyakov requested a review from a team November 28, 2019 17:22
- share the `GeoJSONOptions` instances using `Immutable<GeoJSONOptions>` - avoid extra copying
- fix wrapping of the `GeoJSONOptions` instances in supercluster map/reduce lambdas.
  Previously, local variables were wrapped by reference.
@pozdnyakov pozdnyakov merged commit ab5572b into master Nov 29, 2019
@pozdnyakov pozdnyakov deleted the mikhail_fix_supercluster branch November 29, 2019 07:53
springmeyer pushed a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 13, 2019
captainbarbosa pushed a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 13, 2019
fabian-guerra pushed a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 13, 2019
fabian-guerra added a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 14, 2019
…table GeoJSON sources (V2) (#103)

* Podspec updates for 5.6.0-beta.1

* Bump gl-native submodule to release-tequila

* adapt to mapbox/mapbox-gl-native#15989 (#102)

* More changelog/install updates

* Fix telem dependency docs

* More clarifying documentation

* Fix typo
captainbarbosa pushed a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 14, 2019
…table GeoJSON sources (V2) (#103)

* Podspec updates for 5.6.0-beta.1

* Bump gl-native submodule to release-tequila

* adapt to mapbox/mapbox-gl-native#15989 (#102)

* More changelog/install updates

* Fix telem dependency docs

* More clarifying documentation

* Fix typo
captainbarbosa added a commit to mapbox/mapbox-gl-native-ios that referenced this pull request Dec 14, 2019
…table GeoJSON sources (V2) (#103) (#104)

* Podspec updates for 5.6.0-beta.1

* Bump gl-native submodule to release-tequila

* adapt to mapbox/mapbox-gl-native#15989 (#102)

* More changelog/install updates

* Fix telem dependency docs

* More clarifying documentation

* Fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl needs backport Indicates PR needs to be cherrypicked into a previous release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants