This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Migrate Android SDK to GL JS–powered feedback form #15623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
During my test I also noticed that with some styles, such as |
langsmith
reviewed
Sep 13, 2019
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Show resolved
Hide resolved
langsmith
reviewed
Sep 13, 2019
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Outdated
Show resolved
Hide resolved
pengdev
force-pushed
the
peng-migrate-to-gl-js-feedback-form
branch
from
bf51a07
to
2136556
Compare
|
According to #9078 (comment), on Android side, we will also no longer honor the URLs specified in the href attributes of the tags in the attribution field in the TileJSON. |
pengdev
force-pushed
the
peng-migrate-to-gl-js-feedback-form
branch
from
2136556
to
b4bba42
Compare
pengdev
added
the
needs changelog
tobrun
approved these changes
Sep 18, 2019
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Outdated
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Outdated
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Outdated
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Outdated
Show resolved
Hide resolved
...oid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/AttributionDialogManager.java
Show resolved
Hide resolved
pengdev
force-pushed
the
peng-migrate-to-gl-js-feedback-form
branch
2 times, most recently
from
df0ef77
to
1b1c18f
Compare
pengdev
force-pushed
the
peng-migrate-to-gl-js-feedback-form
branch
from
1b1c18f
to
3ebbde3
Compare
Created #15675 to keep track of this issue. |
langsmith
pushed a commit
that referenced
this pull request
Sep 25, 2019
* [android] Add debug info. * [android] Generate feedback url. * [android] Add unit test for buildMapFeedbackMapUrl. * [android] Remove debug logging. * [android] Add github issue link to the TODO. * [android] Change getPackageName to application context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9090 by constructing the feedback url with referrer(package name), style owner, style id, access token and camera position information(Longitude, Latitude, zoom level, bearing and tilt).
There is one parameter missing since we don't currently have a SDK version API in our Android SDK, so couldn't add the sdk version info to the query parameter. I have created another ticket #15632 to keep track of it.