Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Backport changes for v8.2.2 #15470

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Backport changes for v8.2.2 #15470

merged 5 commits into from
Aug 27, 2019

Conversation

LukasPaczos
Copy link
Member

pozdnyakov and others added 5 commits August 23, 2019 17:04
@pozdnyakov @LukasPaczos
[core] Fix layer impl cast in render layer implementations
f3cf4bc 
This PR puts `impl()` functions definitions into a nameless namespace
to provide internal linkage and to make sure that appropriate cast function
is invoked.

(cherry picked from commit c7169e6)
@tmpsantos @LukasPaczos
[core] Fix use after std::move detected by clang-tidy
d3f6587 
Detected by the bot being setup at
#15385.

(cherry picked from commit 6dfe0e6)
@LukasPaczos
Revert "[android] invalidate camera when setting a padding"
2372176 
(cherry picked from commit baa7086)
@astojilj @LukasPaczos
[core] Fix tileCover / TileCoordinate fromScreenCoordinate(#15442)
11d1e54 
Remove unecessary tile coordinate unproject -> project  step.
Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.

Fixes: #15442

(cherry picked from commit 9eff849)
@LukasPaczos
[android] changelog for v8.2.2
8c15476
@LukasPaczos LukasPaczos added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl labels Aug 23, 2019
pozdnyakov
pozdnyakov approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side

@chloekraw chloekraw added the 🍒 cherry pick Indicates that a PR is a cherry pick. label Aug 26, 2019
@LukasPaczos LukasPaczos merged commit 55243d4 into release-picklejuice Aug 27, 2019
@LukasPaczos LukasPaczos deleted the lp-backport-picklejuice-8.2.2 branch August 27, 2019 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@astojilj astojilj astojilj approved these changes

@pozdnyakov pozdnyakov pozdnyakov approved these changes

@tobrun tobrun tobrun approved these changes

@tmpsantos tmpsantos Awaiting requested review from tmpsantos

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android 🍒 cherry pick Indicates that a PR is a cherry pick. Core The cross-platform C++ core, aka mbgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LukasPaczos @astojilj @pozdnyakov @tobrun @chloekraw @tmpsantos