This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Store type of renderable segment when sorting symbols by key #14517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_use_multiset_for_symbol-sort-keys
branch
2 times, most recently
from
c64b6c4
to
f43e50b
Compare
pozdnyakov
approved these changes
Apr 26, 2019
alexshalamov
force-pushed
the
alexshalamov_use_multiset_for_symbol-sort-keys
branch
from
f43e50b
to
b7ff23d
Compare
alexshalamov
added a commit
that referenced
this pull request
Apr 26, 2019
alexshalamov
added a commit
that referenced
this pull request
Apr 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes container type that allows to store segments with same sort key and also sorts text and icon segments differently, so that if segments have same sort-key, icon would take precedence over text.
Render test: mapbox/mapbox-gl-js#8198
Fixes: #14508
Fixes: #14509