This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Do not include CJK ideographs in the offline packs by default #14269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently blocked by #14271. |
LukasPaczos
added
the
⚠️ DO NOT MERGE
Work in progress, proof of concept, or on hold
label
Mar 29, 2019
This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions. |
LukasPaczos
force-pushed
the
lp-offline-packs-ideographs-14201
branch
from
July 30, 2019 12:03
e26a44e
to
9bb4ba9
Compare
LukasPaczos
removed
the
⚠️ DO NOT MERGE
Work in progress, proof of concept, or on hold
label
Jul 30, 2019
This is ready for a review. /cc @Chaoba @chloekraw |
Both of these two classes not add |
@Chaoba I believe it's required for the offline plugin. |
LGTM |
LukasPaczos
added
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Jul 31, 2019
tobrun
approved these changes
Jul 31, 2019
LukasPaczos
removed
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14201.
/cc @ChrisLoer :)