Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Verify no native method is called when saving state #13980

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #13560.

After investigating the potential map leak it turns out that calls to the MapView from a fragment that's in a backstack can be justified in order to save state. Because the system is not going to dispatch save state calls when the view is being destroyed, the only chance to save state for a fragment that contains a map can be when it's already been replaced during a transition.

The only thing we need to ensure is that during saving state process there are no calls to the native peer, because the renderer can already be destroyed, which has already been done in #13638, this PR adds a test for that case.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Feb 25, 2019
@LukasPaczos LukasPaczos added this to the release-l milestone Feb 25, 2019
@LukasPaczos LukasPaczos merged commit 2ce70f7 into master Mar 4, 2019
@LukasPaczos LukasPaczos deleted the lp-save-state-verification branch March 4, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants