-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core,ios,android] Update feedback URL in code and tests #13710
Conversation
@julianrex @tmpsantos would appreciate your eyes when you have a chance to make sure I didn't break anything on the iOS or core sides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I notice some files in mapbox-gl-js that need updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was looking into #13715 which resulted in PR'ing https://github.com/mapbox/mapbox-gl-native/pull/13732/files. It seems backend is still returning www.mapbox.com/map-feedback
. Since we rely on locally parsing the URL (and redirects won't help us here), we should not update the android code until backend actually returns the correct url.
…ps.mapbox.com/feedback
…s.mapbox.com/feedback
68c4a51
to
3418970
Compare
Thank you, @tobrun, for fixing it up! |
We have recently switched from
www.mapbox.com/feedback
toapps.mapbox.com/feedback
as the preferred way to provide feedback. Before that, we switched fromwww.mapbox.com/map-feedback
towww.mapbox.com/feedback
. This PR updates all occurrences of old URLs to the newapps
one.Fixes #13697.