This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Reuse Bitmap, Paint & Canvas instances in LocalGlyphRasterizer #12488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLoer
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
Looks good pending rebase on master for the latest build fixes. cc @ivovandongen
- Make LocalGlyphRasterizer.drawGlyphBitmap() non-static - Store and reuse Bitmap, Paint & Canvas instances
themics
force-pushed
the
android-localglyphrasterizer-reusing
branch
from
c467f80
to
e738f28
Compare
|
@tobrun Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12421 (Re-open of #12434)
LocalGlyphRasterizer.drawGlyphBitmap()non-static