This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, alternative approach to #12423. This PR differs from #12423 as it doesn't expose a runtime configuration anymore. Providing an alternative httpclient is done at compile time. To support this kind of functionality, two new modules had to be introduced:
How does providing an alternative http client look like for an user:
exclude module: 'MapboxGLAndroidHTTP'
to their Mapbox SDK dependency declarationHttpRequestImpl
in acom.mapbox.mapboxsdk.http
package (as example this is now done in the testapp using ion)Benefits over #12423:
cc @mapbox/maps-android