This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
avoid race condition when calling getMapAsync from OnMapReadyIdlingResource #12308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10998 , this PR moves the invocation in of
getMapAsyncinOnMapReadyIdlingResourceto the main thread. Our tests where suffering from an occasional race condition (1 out 7000 executions) where the style could have been loaded but due to thread switching this was missed when calling getMapSync from the other thread. Will need to do some additional tests run to confirm but I'm hoping proposed code will fix the root cause.cc @mapbox/android as this file has been used in different projects