-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
5e38099
to
2e7ea5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some regression tests to this change?
2e7ea5e
to
e705b12
Compare
* @return bearing in decimal degrees | ||
* @see <a href="http://turfjs.org/docs/#bearing">Turf Bearing documentation</a> | ||
*/ | ||
static double bearing(@NonNull Point point1, @NonNull Point point2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this method's declaration to work with LatLng
s? We would skip unnecessary creation of the Point
object before invoking this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point! Thank you.
59cf184
to
0bf12c8
Compare
de65f0d
to
2b54cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -12,6 +14,7 @@ | |||
import java.util.ArrayList; | |||
import java.util.List; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT - new line
2b54cfd
to
8836f0b
Compare
VisibleRegion on rotated map over antimeridian
closes #12135 , #12463