This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove reflection lookup for MarkerViewAdapter initialization #12218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-remove-reflection
branch
from
5a93593
to
fe09bf1
Compare
tobrun
force-pushed
the
tvn-remove-reflection
branch
from
fe09bf1
to
ce2b6f2
Compare
zugaldia
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the need of using reflection to lookup the class by passing it as an argument instead. Some bytecode optimizers had trouble interpreting these lines. While it breaks semver, I think the severity justifies the cause.