This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Update layer immediately when changing its max/min zoom level (CP #11399) #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [android][core] update layer immediately when changing it's max/min zoom * [core] node bindings for layer zoom range (cherry picked from commit 22b4ef1)
tobrun
approved these changes
Apr 16, 2018
|
@LukasPaczos Is there any reason why mutableImpl is not virtualized? It would allow setters for properties that are common to all layers to be implemented once in Layer::Impl. |
|
The return type would have to be |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP #11399 to the release branch.
This setup includes node bindings for render tests that will start working when #11671 lands.