This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
New gestures library #11221
Merged
New gestures library #11221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/rotate callback
…et focal point when gesture starts as well
…ener interfaces javadoc
LukasPaczos
force-pushed
the
lp-gestures-lib-impl
branch
from
be39499
to
64871c2
Compare
LukasPaczos
commented
Feb 27, 2018
| robolectric : '3.5.1', | ||
| timber : '4.5.1', | ||
| okhttp : '3.9.1' | ||
| mapboxGestures : '0.1.0-20180219.142215-11', |
There was a problem hiding this comment.
Noting that we rely on a particular SNAPSHOT of the gestures library at the moment. This will need to change when the final release of 6.0.0 comes, synced with the first stable release of the gestures library.
|
@tobrun, this PR is ready for the review. |
tobrun
approved these changes
Feb 27, 2018
| <dimen name="mapbox_minimum_scale_span_when_rotating">100dp</dimen> | ||
|
|
||
| <!--Minimum angular velocity required to start rotation animation--> | ||
| <dimen name="mapbox_minimum_angular_velocity">0.025dp</dimen> |
There was a problem hiding this comment.
are above public resources (is a user suppose to override these?)? if yes, these should be exposed in public.xml
There was a problem hiding this comment.
Following up on this in #11331.
| context.getResources().getDimension(R.dimen.mapbox_minimum_angular_velocity) | ||
| )); | ||
| gesturesManager.setShoveGestureListener(new ShoveGestureListener()); | ||
| gesturesManager.setMultiFingerTapGestureListener(new TapGestureListener()); |
There was a problem hiding this comment.
not actionable for now, but for future iterations is to make the initialisation code of the gesture library more discoverable? What I mean with that is that user atm needs to copy paste the code while with something as a builder/factory they could discover the api through specific components and code completion.
There was a problem hiding this comment.
Following up on this in #11331.
|
Can this PR be retargeted to |
|
I'd rather 🍒 pick it to the release branch, not to drag whole |
LukasPaczos
added a commit
that referenced
this pull request
Feb 27, 2018
* [android] new gesture library - added SNAPSHOT dependency * [android] new gesture library - cleaned up redundant classes * [android] new gesture library - limiting scale when rotating * [android] new gesture library - shove gesture filtering * [android] new gesture library - increase rotation threshold when scaling * [android] new gesture library - minimum angular velocity * [android] new gesture library - exposed gestures execution listeners * [android] new gesture library - notifying new listeners tests * [android] new gesture library - removed tracking setting * [android] new gesture library - resetting focal point with every scale/rotate callback * [android] new gesture library - fixed camera change dispatcher callbacks * [android] new gesture library - cancel velocity animations in maps onStop() * [android] new gesture library - extracted telemetry pushes to a method * [android] new gesture library - deprecated onScrollListener * [android] new gesture library - unified shove listener name (cherry picked from commit 7905bd6)
LukasPaczos
added a commit
that referenced
this pull request
Feb 27, 2018
* [android] new gesture library - added SNAPSHOT dependency * [android] new gesture library - cleaned up redundant classes * [android] new gesture library - limiting scale when rotating * [android] new gesture library - shove gesture filtering * [android] new gesture library - increase rotation threshold when scaling * [android] new gesture library - minimum angular velocity * [android] new gesture library - exposed gestures execution listeners * [android] new gesture library - notifying new listeners tests * [android] new gesture library - removed tracking setting * [android] new gesture library - resetting focal point with every scale/rotate callback * [android] new gesture library - fixed camera change dispatcher callbacks * [android] new gesture library - cancel velocity animations in maps onStop() * [android] new gesture library - extracted telemetry pushes to a method * [android] new gesture library - deprecated onScrollListener * [android] new gesture library - unified shove listener name (cherry picked from commit 7905bd6)
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10016.
This PR introduces new gestures handling implementation using mapbox-gestures-android library.
Tagging as work in progress until:
In the meantime, please feel free to run our internal app and give any feedback you might have about gestures composure, thresholds, an order of firing and general behavior so we can tweak them properly before the first iteration.
/cc @mapbox/maps-android