NativeMapView.addImage without copying bitmap into Java

[tobrun]

Follow up from external PR in #11000. Capturing from @ivovandongen that the config validation part should be re-added:

    // Check/correct config
    if (image.getConfig() != Bitmap.Config.ARGB_8888) {
      image = image.copy(Bitmap.Config.ARGB_8888, false);
    }

cc @jaegs

[jaegs]

Maybe the validation part should go here:

mapbox-gl-native/platform/android/src/bitmap.cpp

Lines 112 to 115 in 4d35826

	if (info.format != ANDROID_BITMAP_FORMAT_RGBA_8888) {
	// TODO: convert
	throw std::runtime_error("bitmap decoding: bitmap format invalid");
	}

[tobrun]

@jaegs you are right, will add the conversion on the c++ side.

@ivovandongen I tested image conversion with:

Bitmap bitmap = Bitmap.createBitmap(createColors(), WIDTH, HEIGHT, Bitmap.Config.RGB_565);
mapboxMap.addImage("image", bitmap);

GeoJsonSource geoJsonSource = new GeoJsonSource("source", Feature.fromGeometry(Point.fromCoordinates(new double[] {0, 0})));
mapboxMap.addSource(geoJsonSource);

SymbolLayer symbolLayer = new SymbolLayer("layer", "source");
symbolLayer.withProperties(iconImage("image"));
mapboxMap.addLayer(symbolLayer);

And I was able to debug that the conversion is happening as expected:

This resulted in:

[ivovandongen]

I think this should be static to cache the method lookup

[tobrun]

Could you re-review @ivovandongen? static keyword was added.