Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[release branch] Continue rendering tile despite errors #10012

Commits on Sep 15, 2017

  1. [core] keep tiles renderable even if a subsequent error occurs

    Since 9a9408e, we marked tiles as non-renderable if an error occured. This lead to situations where a tile was loaded + parsed successfully, then a revalidation attempt occured (e.g. because the resource was stale) which failed. In this case, we used to mark the tile as non-renderable although we could've used the perfectly parsed (stale) resource.
    kkaefer committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    987aa98 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2017

  1. [core] make sure tiles are not treated as complete until all worker o…

    …perations completed
    
    Previously, when we started a worker operation that eventually throws an exception (e.g. due to the tile not being parseable), and then enqueue another worker operation while the first one is processing, we treated the worker as idle once the first operation's error callback fired, even though the second operation was still in progress. Due to our use of coalescing, I was unable to come up with a reliable test since we'd need to reproduce the behavior described above, which is timing dependent.
    kkaefer committed Sep 16, 2017
    Configuration menu
    Copy the full SHA
    77a39a1 View commit details
    Browse the repository at this point in the history