Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

It's too easy to rotate the map #6562

Closed
mayagao opened this issue Oct 3, 2016 · 11 comments
Closed

It's too easy to rotate the map #6562

mayagao opened this issue Oct 3, 2016 · 11 comments
Assignees
Labels
iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS UX

Comments

@mayagao
Copy link
Contributor

mayagao commented Oct 3, 2016

When I pinch the screen to zoom in and out of the map, it's too easy to trigger map rotation, which is usually not the intended behavior. This is especially true when I zoom in and out very quickly. Is there anyway we can make it less sensitive? Maybe delay sending the pinch event https://developer.apple.com/reference/uikit/uigesturerecognizer/1624234-delaystouchesbegan or only start rotating when it's more than x degrees?

cc @1ec5 @pveugen

@incanus
Copy link
Contributor

incanus commented Oct 3, 2016

We could listen to the pinch + rotate combination and set a timer in the pinch recognizer. If the rotate recognizer is not also recognized in, say, one full second, disable the rotate recognizer until the pinch is complete.

This will allow folks who do immediately pinch + rotate to freely do so in combination.

@incanus incanus added iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS labels Oct 3, 2016
@incanus
Copy link
Contributor

incanus commented Oct 3, 2016

Or, as @mayagao suggests, only recognize rotate more than x degrees if the pinch is also current in progress.

@friedbunny
Copy link
Contributor

friedbunny commented Oct 3, 2016

My personal perception is that Apple Maps has a slightly higher threshold for engaging rotation during pinches — perhaps ~3-5 degrees. We don’t have any threshold, currently.

I would not be in favor of ignoring rotation entirely during pinch zooms — this is Google’s behavior and I’m often frustrated by not being able to transition into a rotation while zooming.

@1ec5 1ec5 added the Google Maps parity For feature parity with the Google Maps SDK for Android or iOS label Oct 4, 2016
@clydebarrow
Copy link
Contributor

The Android implementation has the opposite problem - rotations are quite hard to trigger.

@milo-trujillo
Copy link

I am seeing this behavior on iOS and Android: users frequently rotate the map by accident while zooming in and out. It would be great if we could add a detection threshold for rotations during pinches, or even make that threshold configurable through the API. If the API is configurable then the developer can choose whether to keep the Google Maps "rotate while zoom" behavior or not.

@Petrulak
Copy link

Petrulak commented May 3, 2017

@friedbunny are there any plans to increase rotation threshold in Android SDK ? Or is it possible to disable map rotation at all ? Zooming in/out with one hand is almost impossible without rotating the map. I have to use 110 % of my "mental capabilities" to not rotate the map and i am not focusing on the data in the map at all. It would be nice to have some consistency with Google Maps since 95% of app out there are using them and user are familiar with certain behavior. It is quite annoying for me that i am always rotating the map while zooming with one hand and i am tilting the map while zooming with 2 fingers.
We are using com.mapbox.mapboxsdk:mapbox-android-sdk:5.0.2@aar
Thank You :)

@percula
Copy link

percula commented Oct 30, 2017

I would also like the ability to increase the rotation threshold and/or the option to disable rotation while pinch-zooming.

@andrewharvey
Copy link
Contributor

andrewharvey commented Feb 25, 2018

I'm seeing this on Android too. Zooming in a few times and my map is upside down from the rotations.

@LukasPaczos
Copy link
Member

@andrewharvey new gestures implementation for Android just landed on master. Please feel free to retest with 6.0.0-SNAPSHOT or upcoming 6.0.0-beta.3 and let us know whether that's still an issue for you.

@friedbunny friedbunny added the UX label Jul 19, 2018
@stale stale bot added the archived Archived because of inactivity label Jan 16, 2019
@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Jan 17, 2019
@friedbunny friedbunny reopened this Feb 8, 2019
@stale stale bot removed the archived Archived because of inactivity label Feb 8, 2019
@jmkiley jmkiley self-assigned this Jun 10, 2019
@friedbunny friedbunny removed the Google Maps parity For feature parity with the Google Maps SDK for Android or iOS label Jun 12, 2019
@jmkiley
Copy link
Contributor

jmkiley commented Dec 9, 2019

Addressed in #15562

Please comment or reopen if this doesn't seem to be resolved.

@jmkiley jmkiley closed this as completed Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS MapKit parity For feature parity with MapKit on iOS or macOS UX
Projects
None yet
Development

No branches or pull requests