Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove addMarkerView in favour of addMarker #5084

Closed
tobrun opened this issue May 20, 2016 · 1 comment · Fixed by #5100
Closed

Remove addMarkerView in favour of addMarker #5084

tobrun opened this issue May 20, 2016 · 1 comment · Fixed by #5100
Assignees
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug

Comments

@tobrun
Copy link
Member

tobrun commented May 20, 2016

Marker views landed with #3276. Currently the API is exposed as:

MarkerView addMarkerView(MarkerViewOptions options)
Marker addMarker(MarkerOptions options);

I prefer exposing one method instead:

MarkerView addMarker(MarkerViewOptions options)
Marker addMarker(MarkerOptions options);

While above is no problem,
the method for adding a List gives: both methods have same erasure

List<Marker> addMarkers(List<? extends BaseMarkerOptions> markerOptionsList);
List<MarkerView> addMarkers(@NonNull List<? extends BaseMarkerViewOptions> markerOptionsList)
@tobrun tobrun added bug Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android labels May 20, 2016
@tobrun tobrun added this to the android-v4.1.0 milestone May 20, 2016
@tobrun
Copy link
Member Author

tobrun commented May 23, 2016

I have decided to go for the simple addMarker for both GL based markers as View based markers. As a result I'm not going to expose a List<MarkerView> addMarkers(@NonNull List<? extends BaseMarkerViewOptions> markerOptionsList).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant