You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
The original Camera API Refinements from #3358 had Callback checks for both REGION_DID_CHANGE_ANIMATED and REGION_DID_CHANGE. The check for REGION_DID_CHANGE was put in for the animateCamera (CameraUpdate update, MapView.CancelableCallback callback) method as it had a 0 time length duration for animation and therefore technically never animated and therefore the Callback was never called. However, this check is leading to some inconsistencies with the full animateCamera (CameraUpdate update, int durationMs, MapView.CancelableCallback callback) method. To solve both problems let's remove the REGION_DID_CHANGE checks in both animateCamera() and easeCamera() AND change the animateCamera() methods sans duration time parameter to use a 1 millisecond duration to trigger the animation functionality but do so in a way that's not noticeable to humans.
The original Camera API Refinements from #3358 had Callback checks for both
REGION_DID_CHANGE_ANIMATED
andREGION_DID_CHANGE
. The check forREGION_DID_CHANGE
was put in for theanimateCamera (CameraUpdate update, MapView.CancelableCallback callback)
method as it had a 0 time length duration for animation and therefore technically never animated and therefore the Callback was never called. However, this check is leading to some inconsistencies with the fullanimateCamera (CameraUpdate update, int durationMs, MapView.CancelableCallback callback)
method. To solve both problems let's remove theREGION_DID_CHANGE
checks in bothanimateCamera()
andeaseCamera()
AND change theanimateCamera()
methods sans duration time parameter to use a 1 millisecond duration to trigger the animation functionality but do so in a way that's not noticeable to humans./cc @zugaldia
The text was updated successfully, but these errors were encountered: