Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

port overscaled line rendering fix from -js #16018

Closed
ansis opened this issue Dec 6, 2019 · 0 comments · Fixed by #16045
Closed

port overscaled line rendering fix from -js #16018

ansis opened this issue Dec 6, 2019 · 0 comments · Fixed by #16045
Assignees
@ansis
Labels
GL JS parity For feature parity with Mapbox GL JS

Comments

@ansis
Copy link
Contributor

ansis commented Dec 6, 2019

mapbox/mapbox-gl-js#9024

We resample lines after sharp corners in some situations. When tiles were really overscaled, sometimes we didn't have enough precision to represent the resampled vertex because it was too close. Disabling this after a certain point prevents this.

before:
Screen Shot 2019-11-25 at 9 55 53 PM
after: Screen Shot 2019-11-25 at 9 56 14 PM
@ansis ansis added the GL JS parity For feature parity with Mapbox GL JS label Dec 6, 2019
ansis added a commit that referenced this issue Dec 6, 2019
@ansis
fix really overscaled lines #16018
fc4f7ad
@ansis ansis self-assigned this Dec 6, 2019
@ansis ansis mentioned this issue Dec 11, 2019
Merged
alexshalamov pushed a commit that referenced this issue Dec 17, 2019
@ansis @alexshalamov
[core] Fix really overscaled lines #16018
864aa11
pozdnyakov pushed a commit that referenced this issue Dec 17, 2019
@ansis @pozdnyakov
[core] Fix really overscaled lines #16018
aa543e4
tobrun pushed a commit that referenced this issue Dec 18, 2019
@ansis @tobrun
[core] Fix really overscaled lines #16018
5a9b92c
tobrun pushed a commit that referenced this issue Dec 18, 2019
@ansis @tobrun
[core] Fix really overscaled lines #16018
a1baafc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ansis ansis

Labels
GL JS parity For feature parity with Mapbox GL JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix really overscaled lines mapbox/mapbox-gl-native
1 participant
@ansis