Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Locally generated glyphs shift on over-zoomed tiles #15405

Closed
chloekraw opened this issue Aug 18, 2019 · 2 comments · Fixed by #15407
Closed

[core] Locally generated glyphs shift on over-zoomed tiles #15405

chloekraw opened this issue Aug 18, 2019 · 2 comments · Fixed by #15407
Labels
Core The cross-platform C++ core, aka mbgl text rendering
Milestone

Comments

@chloekraw
Copy link
Contributor

chloekraw commented Aug 18, 2019

GL-Native version of mapbox/mapbox-gl-js#8653

@asheemmamoowala @mapbox/gl-native @tmpsantos


When zooming from z17 to z18, some locally generated glyphs are being replaced by server retrieved glyphs.

On z18 tiles, the glyphs have variable size which is a property of the server generated glyphs. The z17 tiles have fixed size (24/32 px sq.) size that is characteristic of locally generated glyphs.

platform: iOS and Android
version: 5.2 / 8.2

Demonstration

GIF created from an iOS screen recording:

ezgif-4-be3044fbe602

Also see mapbox/mapbox-gl-js#8653 for helpful visuals on GL-JS.

Expected Behavior

Locally generated glyphs are not overridden by server generated ones.

Actual Behavior

At z18 server glyphs are taking over. Causing a change in the baseline and font of some characters.

@chloekraw chloekraw added beta blocker Blocks the next beta release high priority labels Aug 18, 2019
@chloekraw chloekraw added this to the release-queso milestone Aug 18, 2019
@chloekraw chloekraw added text rendering Core The cross-platform C++ core, aka mbgl labels Aug 18, 2019
@chloekraw
Copy link
Contributor Author

@asheemmamoowala I noticed your native pr #15407 is slimmer than your js pr mapbox/mapbox-gl-js#8657. Is that because some changes on js are not needed in native, or because #15407 is what we can get into queso and other changes could be done as follow-on work for ristretto?

@asheemmamoowala
Copy link
Contributor

@chloekraw I found two additional issues while debugging the root cause of this bug on GL-JS and decide to address them as well. On Native, the local glyphs are already being cached correctly. I haven't yet had a chance to verify the other issue - correct options override in Map#setStyle, but I'll look into it as part of completing the tests for this PR.

@chloekraw chloekraw removed beta blocker Blocks the next beta release high priority labels Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl text rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants