Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix legacy function conversion tests #12747

Open
jfirebaugh opened this issue Aug 27, 2018 · 2 comments
Open

Fix legacy function conversion tests #12747

jfirebaugh opened this issue Aug 27, 2018 · 2 comments
Assignees
Labels
Core The cross-platform C++ core, aka mbgl expressions GL JS parity For feature parity with Mapbox GL JS tests

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Aug 27, 2018

The tests introduced in mapbox/mapbox-gl-js#7095 are failing in native.

Since native converts legacy functions to expressions internally, we want to get all these passing. The first step is to implement support in the test runner, similarly to mapbox/mapbox-gl-js@466162f#diff-a4463a66781c68614988a85564196f32.

@jfirebaugh jfirebaugh added Core The cross-platform C++ core, aka mbgl GL JS parity For feature parity with Mapbox GL JS tests labels Aug 27, 2018
@jfirebaugh jfirebaugh self-assigned this Sep 11, 2018
@jfirebaugh
Copy link
Contributor Author

I started porting mapbox/mapbox-gl-js#7095, but beyond #12864 it gets really tedious and error prone to mimic the exact output of gl-js in this area. We already have a working conversion system in gl-native -- just not one that serializes to expression forms that are compatible with these tests. I think it might be better to pull these tests out into a separate suite that doesn't require identical expression serialization.

@stale stale bot added the archived Archived because of inactivity label Mar 25, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 25, 2019
@tmpsantos tmpsantos reopened this Mar 25, 2019
@stale stale bot removed the archived Archived because of inactivity label Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl expressions GL JS parity For feature parity with Mapbox GL JS tests
Projects
None yet
Development

No branches or pull requests

4 participants