Fix onStyleImageMissing not fired in Snapshotter #317
Conversation
MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/snapshotter/MapSnapshotter.java
Outdated
Show resolved
Hide resolved
| @@ -111,6 +111,13 @@ | |||
| * Called when snapshotter finishes loading it's style. | |||
| */ | |||
| void onDidFinishLoadingStyle(); | |||
|
|
|||
| /** | |||
| * Called when shnashotter finds image missing. | |||
There was a problem hiding this comment.
I also recommend expanding on this functionality for folks who aren't familiar with this feature, e.g.:
Called when snapshotter finds that a style image requested is not present on the spritesheet.
This callback provides an opportunity for the developer to add a style image on-demand to the snapshotter.
Perhaps the implementations in JS and iOS would provide an even better reference for us though.
Whatever we document here should also have parity with the documentation for this callback on Map#Observer.
There was a problem hiding this comment.
Synced with MapView#OnStyleImageMissingListener
| /** | ||
| * Called when shnashotter finds image missing. | ||
| * | ||
| * @param imageName the missing image name |
There was a problem hiding this comment.
do we call images "style images" on Android like we do on iOS? that's where the callback name onStyleImageMissing comes from.
cc/ @mapbox/maps-android
<changelog>Enable adding missing style images on-demand on the map snapshotter.</changelog>cc: @chloekraw