do not reload errored tiles #6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this affect #6768 at all? |
|
@ryanhamley no, this doesn't change the behavior of #6768 as far as I can tell |
anandthakker
approved these changes
Jun 15, 2018
src/source/source_cache.js
Outdated
| @@ -215,7 +215,7 @@ class SourceCache extends Evented { | |||
| this._cache.reset(); | |||
|
|
|||
| for (const i in this._tiles) { | |||
| this._reloadTile(i, 'reloading'); | |||
| if (this._tiles[i] && this._tiles[i].state !== "errored") this._reloadTile(i, 'reloading'); | |||
There was a problem hiding this comment.
Is the first part of the condition necessary, since we're already iterating through the keys of this._tiles?
|
|
||
| t.ok(reloadTileSpy.notCalled); | ||
|
|
||
| t.end(); |
There was a problem hiding this comment.
I had to dig in a bit to convince myself that test would cause reload() to be executed. To make it more obvious, could we have loadTile load one successful tile and one errored tile, and then make sure that we have only one call to _reloadTile?
|
👍 🐑 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6783
errored tiles were being reloaded, and their state was being changed from
errored->reloadingwhich results intile.hasData()to returntrue, preventing the existing parent tiles from being retained correctly.Launch Checklist