Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tile line rendering regression #8477

Closed
jkoelewijn opened this issue Jul 15, 2019 · 3 comments · Fixed by #8479
Closed

Vector tile line rendering regression #8477

jkoelewijn opened this issue Jul 15, 2019 · 3 comments · Fixed by #8479
Assignees
Labels

Comments

@jkoelewijn
Copy link

After upgrading from version 1.0.0 to 1.1.0 we experienced a rendering regression while rendering lines from a vector tile. See screenshot below for comparison between the two versions. An extra almost vertical line is rendered that should not be there.

In #2854 a similar issue has been posted, but in our case we don't get the warning Geometry exceeds allowed extent.

mapbox-gl-js version: 1.1.0

browser: latest Chrome, latest Firefox, latest Edge and latest Internet Explorer

Screenshot

Screenshot of rendering with two versions

Steps to trigger behavior

  1. Visit https://jkoelewijn.github.io/issues/mapbox/mapbox-gl-js/line-rendering-regression/mapbox-gl-js-1.1.0.htm.
  2. Observe that an extra almost vertical line is rendered compared to https://jkoelewijn.github.io/issues/mapbox/mapbox-gl-js/line-rendering-regression/mapbox-gl-js-1.0.0.htm.

Source code of example

https://github.com/jkoelewijn/jkoelewijn.github.io/tree/master/issues/mapbox/mapbox-gl-js/line-rendering-regression

@mourner mourner self-assigned this Jul 15, 2019
@mourner
Copy link
Member

mourner commented Jul 15, 2019

Confirmed. Bisected to #8306. Investigating.

@mourner
Copy link
Member

mourner commented Jul 15, 2019

So, the artifact is expected after #8306 — geometry for that feature indeed exceeds allowed extent. Now we need to investigate why there's no warning about it.

@mourner
Copy link
Member

mourner commented Jul 15, 2019

Fix for both the warning and the artifact pending at #8479.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants