Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requirements for text-radial-offset and text-variable-anchor in style spec #8410

Closed
dereklieu opened this issue Jun 28, 2019 · 1 comment
Closed

Fix requirements for text-radial-offset and text-variable-anchor in style spec #8410

dereklieu opened this issue Jun 28, 2019 · 1 comment
Labels
api 📝 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@dereklieu
Copy link
Contributor

In the style spec reference, text-radial-offset and text-variable-anchor should both have text-field added to their requirements. This would make these two consistent with the other text- properties. As it is, in Studio you can select these two properties when you shouldn't be able to.

text-style-spec

In addition, text-offset should have !: text-variable-anchor in it's requirements in addition to !: text-radial-offset which it already has.

In addition to #8397, we would love to get this fixed before supporting these two new, highly-anticipated properties in Studio :) I'm happy to create a PR for this.
@dereklieu dereklieu mentioned this issue Jul 1, 2019
Merged
@mourner mourner added api 📝 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) labels Jul 2, 2019
@chloekraw
Copy link
Contributor

Closed by #8418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api 📝 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mourner @dereklieu @chloekraw