Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Safari crash under heavy text layout load #8031

Closed
ChrisLoer opened this issue Mar 13, 2019 · 2 comments
Closed

Desktop Safari crash under heavy text layout load #8031

ChrisLoer opened this issue Mar 13, 2019 · 2 comments
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@ChrisLoer
Copy link
Contributor

@jfirebaugh helped me discover a problem! 😄

On Safari Version 12.0.3 (14606.4.5), Mac OS 10.14.3 (18D109), AMD Radeon R9 M370X 2048 MB/Intel Iris Pro 1536 MB, this JSFiddle will crash for me pretty reliably (usually during the first run of the "slider" animation, but sometimes I have to sit and move the slider around for a while):

https://jsfiddle.net/2xf6p9vo/3/

I have no idea what the root cause of the crash is, but I think the relevant stressor is that the animation continually updates the circle-radius property, but because that property is data-driven it also triggers re-layout of the text. The crash doesn't happen when the text isn't showing or is in a different source.

The "Safari crashes when tons of stuff is being sent back and forth between workers and foreground" sounds vaguely like #4695, although in this case the crash seems to happen while the process is only using mid-hundred-MBs of memory.

cc @mourner @ansis

@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Mar 13, 2019
@femski
Copy link

femski commented Apr 4, 2019

Issue with ArrayBuffer not being freed between webworker and main thread has been fixed in iOS 12.2 Safari. See: https://bugs.webkit.org/show_bug.cgi?id=194268
Thank you for the demo that led to resolution. Mapbox on IOS is great again!

@mourner
Copy link
Member

mourner commented Apr 4, 2019

Just confirmed that the JSFiddle above consistently crashes for me in Safari 12.0, but NOT in Safari Technology Preview (12.2), so it indeed seems like the issue was fixed. 🎉

@mourner mourner closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants