Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to migrate a style from legacy functions and filters to expressions #6927

Closed
2 tasks
anandthakker opened this issue Jul 6, 2018 · 0 comments
Closed
2 tasks

Comments

@anandthakker
Copy link
Contributor

We have a module for converting stop functions to expressions (src/style-spec/function/convert.js), so what we need is:

  • A method to convert a legacy filter into an equivalent expression. This doesn't exist internally right now, because we use a specialized code path to handle legacy filters. Note that filters converted to expressions might be slightly less performant than their legacy counterparts because of the overhead necessary to represent the exact legacy type semantics in expressions.
  • A function that takes in a style and traverses & converts all of its layer properties and filters.

cc @nickidlugash @mapbox/studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant