Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LAB/HSL color interpolation for expressions #5326

Closed
mourner opened this issue Sep 19, 2017 · 5 comments
Closed

Implement LAB/HSL color interpolation for expressions #5326

mourner opened this issue Sep 19, 2017 · 5 comments
Labels

Comments

@mourner
Copy link
Member

mourner commented Sep 19, 2017

The expressions PR is already merged into master, but it removed support for LAB/HSL colorSpace property.

We should either add it back before a release (since it's a breaking removal), or remove its support fully (along with color_spaces.js and related code) if we don't plan on also implementing it on the Native side.

cc @anandthakker @kkaefer

@mourner
Copy link
Member Author

mourner commented Sep 19, 2017

Another option would be to roll back expressions-based stop functions conversion until we reach feature and performance parity.

@anandthakker
Copy link
Contributor

Oops, I intended to ticket this follow-up, but forgot to -- thanks @mourner .

@jfirebaugh had an idea about removing the colorSpace property from stop functions, and instead making it part of the *-transition properties.

@mourner
Copy link
Member Author

mourner commented Sep 19, 2017

Hmm, how would that look? trasition properties are for timed fades, while colorSpace controls the way colors are interpolated between stops in a function.

@anandthakker
Copy link
Contributor

trasition properties are for timed fades

Yeah, I think in order to use that approach we'd probably have to broaden the idea of what the transition properties are for. The advantage, though, is that there would be a consistent way to control color interpolation both for DDS and for the case of transitioning between constant paint property values (e.g. via setPaintProperty() / setStyle())

@jfirebaugh jfirebaugh changed the title Reimplement LAB/HSL color interpolation Implement LAB/HSL color interpolation for expressions Sep 30, 2017
@jfirebaugh
Copy link
Contributor

Retitled/de-labeled, given #5379.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants