Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE11] compact attribution not visible in IE11 #3945

Closed
mollymerp opened this issue Jan 10, 2017 · 1 comment
Closed

[IE11] compact attribution not visible in IE11 #3945

mollymerp opened this issue Jan 10, 2017 · 1 comment

Comments

@mollymerp
Copy link
Contributor

mollymerp commented Jan 10, 2017

Same issue as mapbox/mapbox.js#1086 and is caused by an IE bug where descendants an invisible element are also made to be invisible 😞

@mapcarta
Copy link

This is a legal matter because attribution isn't being displayed at all to any Internet Explorer users, whenever using the compact attribution control. Currently (September 2018) fully 9% of our Mapbox GL JS maps loads use Internet Explorer.

There is a simple fix in using a normal element for the icon instead of the ::after pseudo element. Due to a bug, child pseudo elements of a parent with hidden visibility will always be invisible in Internet Explorer even if their visibility is set to visible.

I've found a CSS solution that overrides the default Mapbox style sheet. It seems to work on all browsers and devices.

.mapboxgl-map .mapboxgl-ctrl-attrib.mapboxgl-compact {padding:0; visibility:visible;}
.mapboxgl-map .mapboxgl-ctrl-attrib.mapboxgl-compact:hover {padding:2px 24px 2px 0;}
.mapboxgl-compact > a {display:none;}
.mapboxgl-compact:hover > a {display:inline;}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants