Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use version number directly instead of hash #3689

Closed
huangyingjie opened this issue Nov 23, 2016 · 1 comment
Closed

Please use version number directly instead of hash #3689

huangyingjie opened this issue Nov 23, 2016 · 1 comment

Comments

@huangyingjie
Copy link

Report an improvement

Current

    "mapbox-gl-function": "mapbox/mapbox-gl-function#41c6724e2bbd7bd1eb5991451bbf118b7d02b525",
    "mapbox-gl-shaders": "mapbox/mapbox-gl-shaders#bc72d7b0def94cb8388ab4add183b52c84d5128e",
    "mapbox-gl-style-spec": "mapbox/mapbox-gl-style-spec#77434bd0bdb623809c85afaa3da432ebe01e993f",

expect

    "mapbox-gl-function": "~x.y.z",
    "mapbox-gl-shaders": "~x.y.z",
    "mapbox-gl-style-spec":  "~x.y.z"

reason

npm verb git clone --template=/root/.npm/_git-remotes/_templates --mirror git://github.com/mapbox/mapbox-gl-function.git /root/.npm/_git-remotes/git-github-com-mapbox-mapbox-gl-function-git-41c6724e2bbd7bd1eb5991451bbf118b7d02b525-53c3845b: fatal: unable to connect to github.com:
npm verb git clone --template=/root/.npm/_git-remotes/_templates --mirror git://github.com/mapbox/mapbox-gl-function.git /root/.npm/_git-remotes/git-github-com-mapbox-mapbox-gl-function-git-41c6724e2bbd7bd1eb5991451bbf118b7d02b525-53c3845b: github.com[0: 192.30.253.112]: errno=Connection timed out
npm verb git clone --template=/root/.npm/_git-remotes/_templates --mirror git://github.com/mapbox/mapbox-gl-style-spec.git /root/.npm/_git-remotes/git-github-com-mapbox-mapbox-gl-style-spec-git-77434bd0bdb623809c85afaa3da432ebe01e993f-fe7202af: github.com[0: 192.30.253.112]: errno=Connection timed out
npm verb git clone --template=/root/.npm/_git-remotes/_templates --mirror git://github.com/mapbox/mapbox-gl-style-spec.git /root/.npm/_git-remotes/git-github-com-mapbox-mapbox-gl-style-spec-git-77434bd0bdb623809c85afaa3da432ebe01e993f-fe7202af: github.com[1: 192.30.253.113]: errno=Connection timed out

Connection to github always got timeout in China. If using npm version instead, we can use npm private registery.

@mourner
Copy link
Member

mourner commented Nov 23, 2016

Thanks for the report! We're going to solve this as a part of #3656.

@mourner mourner closed this as completed Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants