Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default contents for Marker #3557

Closed
jfirebaugh opened this issue Nov 7, 2016 · 6 comments
Closed

Provide default contents for Marker #3557

jfirebaugh opened this issue Nov 7, 2016 · 6 comments

Comments

@jfirebaugh
Copy link
Contributor

For closer parity with Leaflet markers, the element parameter to the Marker class should be optional, and the default should be render a traditional marker pin icon similar to image.

For implementation, I suggest that this use some inline SVG source, so as not to require an external asset.

@mikehatfield
Copy link

Any progress on this?

@jfirebaugh
Copy link
Contributor Author

@mikehatfield Nope -- want to work on a PR?

@rahuldhawani
Copy link

Anyone working on this? If not, then I would like to pick it up.

@jfirebaugh
Copy link
Contributor Author

Go for it @rahuldhawani!

@samanpwbb
Copy link
Contributor

I recommend this marker, for consistency across gl native / mapbox's static image API: https://github.com/mapbox/makiwich/blob/master/sources/marker-large.svg

@Qwertie-
Copy link

This would be very helpful. It's overly complex to add a basic marker to the map currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants