Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitchstart and pitchend events #2449

Closed
lucaswoj opened this issue Apr 14, 2016 · 5 comments · Fixed by #4473
Closed

Add pitchstart and pitchend events #2449

lucaswoj opened this issue Apr 14, 2016 · 5 comments · Fixed by #4473

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Apr 14, 2016

zoom has zoomstart and zoomend

rotate has rotatestart and rotateend (see #2448)

pitch is all alone

@redbmk
Copy link

redbmk commented Jan 7, 2017

I'm actually having a hard time finding anywhere in the code that triggers a pitch event at all. I'm looking through the latest code for it, and map.on('pitch', data => console.log(data)) never fires for me in version 0.28.0.

@redbmk
Copy link

redbmk commented Jan 7, 2017

Ah, looks like that part of an open issue in #3357. Would that make this a duplicate then, since that issue also mentions making sure that pitchstart and pitchend fire?

@NoMemoryError
Copy link

Is this still being worked on? Any update on this ? Firing moveend zoomend event on every touch really effects the performance.

@mollymerp
Copy link
Contributor

@Vypah yep I'm working on this as part of #4253 !

@NoMemoryError
Copy link

@mollymerp great 👍 I really hope that this will address #3435 once we start distinguishing between touch events and other events like moveend, zoomend. During multi-touch, eg. two fingers touching the screen at the same time, moveend is fired on every single animation frame for the duration of the gesture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants