Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have two words for "Layer" #1237

Closed
tmcw opened this issue Jun 2, 2015 · 10 comments
Closed

Have two words for "Layer" #1237

tmcw opened this issue Jun 2, 2015 · 10 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Jun 2, 2015

  • Layers are things you define in a style
  • Layers are also things in a datasource

Two concepts deserve two words

@tmcw
Copy link
Contributor Author

tmcw commented Jun 2, 2015

Given that in Painter, layers from tiles are VectorTileLayer instances, I think we should call them vectorTileLayer.

@peterqliu
Copy link
Contributor

layers from tiles are VectorTileLayer instances

would this be # 1 or # 2 in your list?

@tmcw
Copy link
Contributor Author

tmcw commented Jun 2, 2015

I'm not sure what you mean. Say more?

@peterqliu
Copy link
Contributor

Just confused whether "layers from tiles" means

Layers are things you define in a style

or

Layers are also things in a datasource

@tmcw
Copy link
Contributor Author

tmcw commented Jun 2, 2015

The second. Datasources have tiles which have layers

@peterqliu
Copy link
Contributor

I get the feeling that anything long, like vectorTileLayer would get shorthanded back to "layer" over time.

How about a different word altogether? A crack at the thesaurus: source-level and source-section resonate with me.

screen shot 2015-06-03 at 3 41 21 pm

@anandthakker
Copy link
Contributor

Not that anyone asked me, but I like @peterqliu's notion of chucking "layer" altogether. And if that's gonna happen, it seems to me like the layers in a vector tile source are very close analogues to FeatureCollections, so maybe something along those lines?

@nickidlugash
Copy link

Layers are also things in a datasource

In the app we're calling these "subsets", right? I also like the idea of getting rid of "layer" altogether for these. Layers suggest groups that get stacked on top of each other (as style layers do), but data layers are more amorphous than that (at least in GL).

@tmcw
Copy link
Contributor Author

tmcw commented Mar 21, 2016

Indeed, we always call vector-layers subsets in Studio

2016-03-21 at 6 53 pm

Question is whether mapbox-gl-style-spec, gl-js, gl-native, and so on can or should eventually use the same terminology / cc @lucaswoj

@lucaswoj
Copy link
Contributor

Question is whether mapbox-gl-style-spec, gl-js, gl-native, and so on can or should eventually use the same terminology

This would be a huge cross-product change. We should discuss in mapbox/DEPRECATED-mapbox-gl#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants