-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove map event creation code #373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
============================================
+ Coverage 60.71% 61.78% +1.06%
+ Complexity 567 511 -56
============================================
Files 105 98 -7
Lines 3332 2962 -370
Branches 228 207 -21
============================================
- Hits 2023 1830 -193
+ Misses 1208 1032 -176
+ Partials 101 100 -1 |
hey @Chaoba thanks for starting looking into it. a quick note here: the gist of the ticket is to move all map events to |
5e5edf0
to
f303a92
Compare
@andrlee We should also create a PR for auto, right? |
e5fc971
to
9a1d071
Compare
libtelemetry/src/main/java/com/mapbox/android/telemetry/MapBuildEvent.java
Outdated
Show resolved
Hide resolved
libtelemetry/src/main/java/com/mapbox/android/telemetry/Event.java
Outdated
Show resolved
Hide resolved
libtelemetry/src/main/java/com/mapbox/android/telemetry/NavigationFasterRouteEvent.java
Outdated
Show resolved
Hide resolved
13c110b
to
e4e5bd3
Compare
e4e5bd3
to
d517ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chaoba LGTM! Let's merge and test mapbox/mapbox-gl-native#14309 with snapshot.
Fix #203.
Remove map event creation code and corresponding test code.
The corresponding PR for map sdk is mapbox/mapbox-gl-native#14309