Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map event creation code #373

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Remove map event creation code #373

merged 3 commits into from
Apr 8, 2019

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Mar 29, 2019

Fix #203.
Remove map event creation code and corresponding test code.

The corresponding PR for map sdk is mapbox/mapbox-gl-native#14309

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #373 into master will increase coverage by 1.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
+ Coverage     60.71%   61.78%   +1.06%     
+ Complexity      567      511      -56     
============================================
  Files           105       98       -7     
  Lines          3332     2962     -370     
  Branches        228      207      -21     
============================================
- Hits           2023     1830     -193     
+ Misses         1208     1032     -176     
+ Partials        101      100       -1

@Chaoba Chaoba requested a review from andrlee March 29, 2019 05:42
@andrlee
Copy link
Contributor

andrlee commented Mar 29, 2019

hey @Chaoba thanks for starting looking into it. a quick note here: the gist of the ticket is to move all map events to mapbox-gl-native while maintaining backwards compatibility. so essentially we need to cut two PRs: one that removes all maps events from events repo and another one that adds them to maps sdk. Please consult with @tobrun or @LukasPaczos about what is the right place for these events

@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 3, 2019

@andrlee We should also create a PR for auto, right?

Copy link
Contributor

@andrlee andrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chaoba LGTM! Let's merge and test mapbox/mapbox-gl-native#14309 with snapshot.

@Chaoba Chaoba merged commit 6851cb8 into master Apr 8, 2019
@Chaoba Chaoba deleted the kl-remove-event-factory branch April 8, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants