Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Update bottomBoundaryValue when new docs-page-shell lands #82

Closed
colleenmcginnis opened this issue Dec 21, 2018 · 1 comment · Fixed by #88
Closed

Update bottomBoundaryValue when new docs-page-shell lands #82

colleenmcginnis opened this issue Dec 21, 2018 · 1 comment · Fixed by #88

Comments

@colleenmcginnis
Copy link
Contributor

Just want to note that we'll want to adjust the bottomBoundaryValue in the PageLayout component when the new docs-page-shell lands. This value determines when the table of contents in the sidebar should unstick at the bottom of the page. That 450 value is specific to the bigger footer that we are currently using in the page shell. The new docs-page-shell will have a much smaller footer so we'll want to adjust.

bottomBoundaryValue: height - 450

cc @katydecorah

@katydecorah
Copy link
Contributor

Good catch, @colleenmcginnis!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants