@@ -332,6 +333,7 @@ exports[`overview-header All, plus Contact Us button renders as expected 1`] = `
className="none block-mxl"
>
@@ -516,6 +518,7 @@ exports[`overview-header Basic renders as expected 1`] = `
className="none block-mxl"
>
@@ -679,6 +682,7 @@ exports[`overview-header Beta product renders as expected 1`] = `
className="none block-mxl"
>
@@ -859,6 +863,7 @@ exports[`overview-header No optional props renders as expected 1`] = `
className="none block-mxl"
>
@@ -1031,6 +1036,7 @@ exports[`overview-header Some optional props renders as expected 1`] = `
className="none block-mxl"
>
diff --git a/src/components/overview-header/__tests__/overview-header-test-cases.js b/src/components/overview-header/__tests__/overview-header-test-cases.js
index 38179255c..1799f1bd3 100644
--- a/src/components/overview-header/__tests__/overview-header-test-cases.js
+++ b/src/components/overview-header/__tests__/overview-header-test-cases.js
@@ -28,7 +28,10 @@ testCases.none = {
],
title: "Mapbox SDK that You've Never Heard Of",
image: (
-
+
)
}
};
@@ -42,7 +45,10 @@ testCases.some = {
version: '0.1.0',
ghLink: 'https://github.com/mapbox',
image: (
-
+
)
}
};
@@ -55,7 +61,10 @@ testCases.beta = {
title: 'Mapbox Potato SDK',
tag: 'beta',
image: (
-
+
)
}
};
@@ -72,7 +81,10 @@ testCases.allContactUs = {
ghLink: 'https://github.com/mapbox',
contactLink: 'https://www.mapbox.com/contact/',
image: (
-
+
)
}
};
@@ -87,7 +99,10 @@ testCases.contactUs = {
changelogLink: 'https://keepachangelog.com/en/0.3.0/',
contactLink: 'https://www.mapbox.com/contact/',
image: (
-
+
)
}
};
@@ -109,7 +124,10 @@ testCases.customTag = {
}
},
image: (
-
+
)
}
};
@@ -130,7 +148,10 @@ testCases.everything = {
ghLink: 'https://github.com/mapbox',
contactLink: 'https://www.mapbox.com/contact/',
image: (
-
+
)
}
};
diff --git a/src/components/overview-header/examples/basic.js b/src/components/overview-header/examples/basic.js
index 66d8cca32..80bcedae5 100644
--- a/src/components/overview-header/examples/basic.js
+++ b/src/components/overview-header/examples/basic.js
@@ -19,7 +19,10 @@ export default class Basic extends React.PureComponent {
installLink="https://www.mapbox.com/install"
ghLink="https://github.com/mapbox"
image={
-
+
}
/>
);
diff --git a/src/components/overview-header/examples/custom.js b/src/components/overview-header/examples/custom.js
index e4895788a..aea372394 100644
--- a/src/components/overview-header/examples/custom.js
+++ b/src/components/overview-header/examples/custom.js
@@ -13,7 +13,10 @@ export default class Custom extends React.PureComponent {
theme="bg-blue"
lightText={true}
image={
-
+
}
/>
);
diff --git a/src/components/related-page/__tests__/__snapshots__/related-page.test.js.snap b/src/components/related-page/__tests__/__snapshots__/related-page.test.js.snap
index c228a2261..5b09e6a63 100644
--- a/src/components/related-page/__tests__/__snapshots__/related-page.test.js.snap
+++ b/src/components/related-page/__tests__/__snapshots__/related-page.test.js.snap
@@ -821,7 +821,7 @@ exports[`related-page tutorial renders as expected 1`] = `
`;
exports[`related-page video renders as expected 1`] = `
-
@@ -906,11 +906,11 @@ exports[`related-page video renders as expected 1`] = `
-
+
`;
exports[`related-page video with svg image fallback renders as expected 1`] = `
-
@@ -987,5 +987,5 @@ exports[`related-page video with svg image fallback renders as expected 1`] = `
-
+
`;
diff --git a/src/components/related-page/related-page.js b/src/components/related-page/related-page.js
index df27f1100..df212d922 100644
--- a/src/components/related-page/related-page.js
+++ b/src/components/related-page/related-page.js
@@ -109,11 +109,16 @@ class RelatedPage extends React.PureComponent {
wmin180: showVideoThumbnail
});
+ const Element = showVideoModal ? 'button' : 'a';
+ const elementProps = {
+ ...(showVideoModal && { onClick: this.handleClick }),
+ ...(!showVideoModal && { href: props.url })
+ };
+
return (