Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Mismatch Issue: Incorrect Type Assignment for Checkbox Field #35

Open
SvenBudak opened this issue Sep 30, 2023 · 3 comments
Open

Comments

@SvenBudak
Copy link

I just noticed a problem with the types. I created a new field of type checkbox, but your extension sets the following type:

gender?: unknown | null;

However, this somehow doesn’t make sense...

The correct type would be:

gender?: string[] | null;

Can someone confirm that this is a bug?

chrome_85fyPu4quL.mp4
@Dominic-Marcelino
Copy link
Contributor

Dominic-Marcelino commented Oct 6, 2023

@SvenBudak
I'm not a maintainer of this module, so just for information:
In your screencast the JSON field-type is used. The generator currently always uses unknown for json and csv fields:

else if (["json", "csv"].includes(field.type)) type = "unknown";

@SvenBudak
Copy link
Author

JSON is the only option that make multi select possible for "checkbox" maybe it makes sense to add a special rule for checkboxes then...

@maxbec
Copy link

maxbec commented Jan 17, 2024

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants