Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack !fs issue #14

Open
aakilfernandes opened this issue Jan 11, 2017 · 2 comments
Open

Webpack !fs issue #14

aakilfernandes opened this issue Jan 11, 2017 · 2 comments

Comments

@aakilfernandes
Copy link

Webpack breaks with the usage of !fs. Can we switch to another way of checking the browser? ie typeof window === 'undefined'

https://github.com/mafintosh/pump/blob/master/index.js#L12

ipfs-inactive/js-ipfs-http-client#507

@dignifiedquire
Copy link
Contributor

When are you seeing this issue? the browser field in package.json declares fs=false, so webpack and browserify should replace fs with null, resulting in the correct check.

@aakilfernandes
Copy link
Author

Ah. I'm getting it when trying to build a project with ipfs-api as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants