infinite rendering invalidation detected in 0.8.x

[kellyselden]

I'm finally getting around to a 0.8.x update and getting Error: infinite rendering invalidation detected

https://travis-ci.org/kellyselden/package-hint-historic-resolver/jobs/217892855#L1375

[machty]

@kellyselden can you provide some links into your codebase where you think these errors might be originating from? Like if it's on a specific page/component render, it'd help to know which specific task to look at.

Also, are you getting this in localhost, or just on travis?

[kellyselden]

Here is a task causing the loop: https://github.com/kellyselden/package-hint-historic-resolver/blob/2a8adc11a888af271885a71b58b097f6cd8a1a7d/app/services/task.js#L48-L57

Here is a trace. Unfortunately the trace doesn't help me track down the issue, it only gave me the ajax call responsible, which lead me to the correct task calling it.

ember.debug.js:12240 Uncaught Error: infinite rendering invalidation detected
    at Array.loopEnd (ember.debug.js:12240)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Array.loopEnd (ember.debug.js:12243)
    at Backburner._trigger (ember.debug.js:634)
    at Backburner.end (ember.debug.js:610)
    at Backburner.run (ember.debug.js:713)
    at Backburner.join (ember.debug.js:744)
    at Function.run.join (ember.debug.js:22732)
    at Object.hash.success (ajax-request.js:231)
    at fire (jquery.js:3317)
    at Object.fireWith [as resolveWith] (jquery.js:3447)
    at done (jquery.js:9272)
    at jquery.js:9514
    at FakeRequest.<anonymous> (fake_xml_http_request.js:137)
    at FakeRequest.dispatchEvent (fake_xml_http_request.js:181)
    at FakeRequest._readyStateChange (fake_xml_http_request.js:381)
    at FakeRequest._setResponseBody (fake_xml_http_request.js:445)
    at FakeRequest.respond (fake_xml_http_request.js:466)
    at Object.callback (pretender.js:369)
    at Pretender.resolve (pretender.js:418)
    at pretender.js:409

[machty]

I'm working through this right now; don't have a clear idea yet what the root cause is, but it's clued me into some undesirable scheduler behavior that's causing some extra stack frame bloat that I hadn't planned on. I'm gonna try and address that issue and honestly I wouldn't be surprised if it just fixed your test case; will follow up with some findings hopefully soon.

[kellyselden]

Thanks. BTW, I'm not blocked on this, so don't stress out about fixing it.

[machty]

It's no problem; TBH I've been a bit nervous about the 0.8.x changes and this sort of bug is what I was afraid of, so it's good to have a real world example of it being a problem that I can address and hopefully ease my mind.

[knownasilya]

Also seeing this, I downgraded for now.

[kellyselden]

@knownasilya I believe @machty found it to be related to having ember-browserify/browserify in your dependencies. Can you confirm?

[knownasilya]

I don't have it as a dependency.

[machty]

No, it's not related to browserify; my ability to debug package-hint-historic-resolver without generator transpilation was impacted, but the bug presents in both cases and I haven't found the source of it yet.

[kellyselden]

Shoot my mistake. I remembered it wrong.

[amiel]

I'm also running in to this issue. I'd be happy to dig in more with guidance on what would be helpful.