Confusing metrics.globalVariables vs offenders.globalVariables output

[pdehaan]

Steps to reproduce:

1. Run Phantomas from the command line and set the reporter to JSON:
   $ sudo phantomas --url https://foo.org/signup --reporter json
2. Compare the metrics.globalVariables and offenders.globalVariables results:

    "globalVariables": 12,

But the globalVariables array is an array with one element

    "globalVariables": [
      "$, Backbone, Modernizr, _, define, html5, jQuery, jQuery110206297926814295352, require, requirejs, router, translator"
    ],

Actual results:

metrics.globalVariables == 12, but the offenders.globalVariables only has a single item in it's array (which is a ", " delimited string):

offenders.globalVariables[0] = "$, Backbone, Modernizr, _, define, html5, jQuery, jQuery110206297926814295352, require, requirejs, router, translator"

Expected results:

Each global variable should be its own array element (something like offenders.globalVariables = offenders.globalVariables[0].split(", "))

• offenders.globalVariables[0] === "$"
• offenders.globalVariables[1] === "Backbone"
• ...
• offenders.globalVariables[11] === "translator"

[macbre]

@pdehaan, good point. I was considering this approach when implementing this.