fix: Kit Initialization & De-Initialization. #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underlying issues is calling fetchConfig when no kit instance is assigned to KitFrameworkManager, therefore the because the instance is null, we cant pass the kits to to apiClient. Removing empty validation in ConfigManager since this is a valid case.
samdozor
approved these changes
Jul 3, 2023
mparticle-automation
added a commit
that referenced
this pull request
Jul 5, 2023
## [5.51.4](v5.51.3...v5.51.4) (2023-07-05) ### Bug Fixes * Kit Initialization & De-Initialization. ([#398](#398)) ([42560f1](42560f1))
|
🎉 This PR is included in version 5.51.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@einsteinx2 @markvdouw I have a tech writing ticket (TW-1204) that was automatically created for this bug - from from what I can tell, there's no actual doc impact. Can I mark my ticket as "won't do", or am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Kit Initialization & De-Initializationg.
Instructions
developmentSummary
The underlying issues is that when the KitFrameworkManager calls fetchConfig, the kitConfig instance is null (the instance created not yet assigned). Therefore, the ApiClient can get the "supported kits" from the [KitManager.KitIntegrationFactory] and the mp-kit header is not added to the call, resulting in a response with "eks" empty.
The fix includes assigning the KitManager instance before calling configure kits (which will fetch the config).
The kitManager config will anyway be reassigned in the configuration callback.
Removing empty validation in ConfigManager since this is a valid case.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)