From 6f8772def49071b712f2819400a2d0871c016a81 Mon Sep 17 00:00:00 2001 From: mski_iksm <9000000000000000091e@gmail.com> Date: Sat, 28 Sep 2024 14:40:37 +0900 Subject: [PATCH 1/3] dont extract value from dict --- gokart/task.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/gokart/task.py b/gokart/task.py index 42c00bf9..309b0d09 100644 --- a/gokart/task.py +++ b/gokart/task.py @@ -291,8 +291,6 @@ def _load(targets): return targets.load() data = _load(self._get_input_targets(target)) - if target is None and isinstance(data, dict) and len(data) == 1: - return list(data.values())[0] return data @overload From c402f7563cf48a302e1e6a3f8012729431389192 Mon Sep 17 00:00:00 2001 From: mski_iksm <9000000000000000091e@gmail.com> Date: Sat, 28 Sep 2024 17:45:56 +0900 Subject: [PATCH 2/3] fix test --- test/test_task_on_kart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_task_on_kart.py b/test/test_task_on_kart.py index 4ddc22fc..e3946b49 100644 --- a/test/test_task_on_kart.py +++ b/test/test_task_on_kart.py @@ -267,7 +267,7 @@ def test_load_with_single_dict_target(self): data = task.load() target.load.assert_called_once() - self.assertEqual(data, 1) + self.assertEqual(data, {'target_key': 1}) def test_load_with_keyword(self): task = _DummyTask() From 687ad6d5ffa009d094151170329feac54912e9b0 Mon Sep 17 00:00:00 2001 From: mski_iksm <9000000000000000091e@gmail.com> Date: Sun, 29 Sep 2024 00:07:24 +0900 Subject: [PATCH 3/3] fix --- gokart/task.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gokart/task.py b/gokart/task.py index 309b0d09..2f351d2a 100644 --- a/gokart/task.py +++ b/gokart/task.py @@ -290,8 +290,7 @@ def _load(targets): return {k: _load(t) for k, t in targets.items()} return targets.load() - data = _load(self._get_input_targets(target)) - return data + return _load(self._get_input_targets(target)) @overload def load_generator(self, target: Union[None, str, TargetOnKart] = None) -> Generator[Any, None, None]: ...