Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

"Open Link in Background Tab" opens two tabs instead one #335

Open
velkyel opened this issue Dec 26, 2021 · 11 comments · May be fixed by #338
Open

"Open Link in Background Tab" opens two tabs instead one #335

velkyel opened this issue Dec 26, 2021 · 11 comments · May be fixed by #338

Comments

@velkyel
Copy link

velkyel commented Dec 26, 2021

my browser: firefox 96.0b9 (64-bit), linux ubuntu

@plomari
Copy link

plomari commented Jan 14, 2022

I think this happened because of the update from firefox 95 to firefox 96.
Very unfortunate, makes this extension almost unusable.

@plomari
Copy link

plomari commented Jan 15, 2022

This is happening with similar extensions too, might give a hint what the underlying problem is: philc/vimium#3986

@Seanld
Copy link

Seanld commented Jan 17, 2022

Also occurring on Arch Linux, Firefox 96. Can't recall if this was happening before the update to 96, or just after.

@Mojavve
Copy link

Mojavve commented Jan 19, 2022

Just noticed this issue as well although I'm on nightly 98.0a1. Arch Linux as well. It's probably obvious but worth noting this also happens when you open link in foreground tab as well.

@ris58h
Copy link

ris58h commented Feb 24, 2022

@eejdoowad Could we have fix for it? It's already been fixed in Vimium.

@Seanld
Copy link

Seanld commented Feb 24, 2022

I have a semi fix at #337. I don't know where to put the userAgentMatch such that it only gets executed once, when the extension is loaded, rather than every time an event occurs (unnecessary repetition, as the user agent probably won't be changing that often).

It checks to see if the Firefox user agent is >= 96 before applying the fix, as that's about when it broke. But the problem is: I'm on Arch, which has the latest Firefox build available (96). But when I was testing, Firefox was still reporting the user agent string as Firefox 91 (even after a kill and relaunch of Firefox). So the version check isn't effective for me. I tested this with Vimium, which @ris58h above just mentioned has already had this fixed a month ago, and the version check they use also doesn't work for me. The tab duplication persists.

Is this Mozilla's bug, or something I'm missing? I'm not a web developer, so this is new to me.

@Seanld
Copy link

Seanld commented Feb 24, 2022

Nevermind, it looks like the user agent problem is because I have privacy.resistFingerprinting set to true in about:config [1]. Disabling it sets an up-to-date user agent. That's going to be yet another problem though, for users that want their privacy. Perhaps a menu option in the extension popup to override the behaviour manually?

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1489903

@ris58h
Copy link

ris58h commented Feb 24, 2022

@Seanld it seems like Vimium has PR for fixing the issue with privacy.resistFingerprinting philc/vimium#4000

@seanjennings960
Copy link

Not sure what's going on with the privacy.resistFingerprinting, but building off of all the links in this issue and #337, I may have a fix here: seanjennings960#2.

@gdh1995
Copy link

gdh1995 commented May 22, 2022

As said in philc/vimium#4000 (comment),

Firefox will report a version of "91.0" in navigator.userAgent, if only privacy.resistFingerprinting on about:config is enabled.

Updated on 2022/08/09:
I was still curious about why it's Firefox 96 which began to behave differently, so according to the clue about Firefox 91.6.0esr, today I compared 91.5.1esr and 91.6.0esr and successfully found the root difference.

It's the bug fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1739929 from Firefox team, and it's imported to make GMail work on it. Sadly to learn that complaints from us extension developers didn't make any contribution in it.

@ibnishak
Copy link

Any progress on this issue? It persists on Firefox Developer Edition v105 in Arch Linux as of today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants